On Wed, 30 Oct 2024 19:13:20 GMT, Fernando Guallini <fguall...@openjdk.org> 
wrote:

>> Several tests currently use weak key and salt sizes. Since the purpose of 
>> these tests is not to evaluate weak keys, they can be updated to use 
>> stronger keys length (2048-bits) and stronger Salt (16 bytes). This PR does 
>> not intend to update the tests to use stronger algorithms.
>> 
>> There is no significant increase in tests run time, those still complete 
>> consistently fast (few seconds).
>
> Fernando Guallini has updated the pull request with a new target base due to 
> a merge or a rebase. The pull request now contains 13 commits:
> 
>  - Merge branch 'master' into 8342181
>  - simplified getTestKeySize
>  - minor changes in SecurityUtils comments and enum moved
>  - Merge branch 'master' into 8342181
>  - KeyToolTest.java will be updated in another PR
>  - Fix algo mistake in SignatureKeyInfo
>  - Updated tests that were already using 2048 to use securityUtils instead
>  - Convert bits to bytes when necessary
>  - Using SecurityUtils to define the keysize and salt size
>  - removed test 3072 from SupportedDSAParamGen.java
>  - ... and 3 more: https://git.openjdk.org/jdk/compare/9a9ac1d0...7827baa8

Marked as reviewed by rhalade (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21537#pullrequestreview-2406357606

Reply via email to