On Mon, 23 Sep 2024 17:47:17 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> src/java.base/share/classes/javax/crypto/KDF.java line 653: >> >>> 651: pdebug.println( >>> 652: "The evaluated provider does not support >>> the " >>> 653: + "specified algorithm and parameters"); >> >> `nsae.printStackTrace(pdebug.getPrintStream());` > > Addressed in > https://github.com/openjdk/jdk/pull/20301/commits/315f90e6e8572dfaea0fdb4f5d94452637a7e423. You can keep the existing `pdebug.println` line. Maybe put a line before lines 608 and 622 as well. When a program terminated with an exception, it's usually OK to just dump the exception there without a comment since it's not handled. In this case, we actually handle the exception, and it's better to add a comment on how we handled it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1773814906
