On Sun, 22 Sep 2024 13:36:39 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> spec wording changes and a few tweaks to DPS > > src/java.base/share/classes/javax/crypto/KDF.java line 116: > >> 114: private Delegate theOne; >> 115: //guarded by 'lock' >> 116: private Delegate candidate; > > Since `candidate` is never modified, make it `final`. Addressed in https://github.com/openjdk/jdk/pull/20301/commits/315f90e6e8572dfaea0fdb4f5d94452637a7e423. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1771978146