On Wed, 4 Sep 2024 22:08:22 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> Given the changes to the System.console() behavior, where it no longer 
>> returns null when a write pipe is connected to the Java process, keytool 
>> needs to be updated to determine whether an interactive terminal is attached.
>
> Do you need to check `Password::readPassword(InputStream in, boolean 
> isEchoOn)` also? I'm not sure.

@wangweij Thanks for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20855#issuecomment-2332555827

Reply via email to