On Tue, 3 Sep 2024 22:10:44 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Addressed in >> https://github.com/openjdk/jdk/pull/20301/commits/6b7a75da2ebb1cc9d95628018d756e2ce2162768. >> Please review and confirm if resolved. > > The new paragraph is a little too long. Something like "Users provide request > params ti getInstance, and get actual params in getParams(). See > KDF.getParams for details" is enough. This paragraph is only 3 sentences. I've re-read it, and it seems fine. This will remain "as-is". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1745919018