On Wed, 28 Aug 2024 20:37:19 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> The way this is worded it is part of the API specification, so I would >> expect `IllegalArgumentException` to be thrown if the length is less than >> 255 * HMAC length. But as I understand, only the HKDF impl can do that. I >> would change this to only say the length must be greater than 0, and add an >> "Implementation Note" that says HKDF implementations will enforce that the >> length is less than 255 * HMAC length. > > Resolved in > https://github.com/openjdk/jdk/pull/20301/commits/a65dc9da044297c313e02d698255bad915dc0a10. Thanks for the update. The `prk` one also needs to be mentioned. I should have added a comment yesterday. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1736305955
