On Thu, 29 Aug 2024 18:57:59 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - consistency with wording for addIKM and addSalt >> - another round of code review comments > > src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java > line 147: > >> 145: // we should be able to combine these Lists of key segments >> into >> 146: // single SecretKey Objects, unless we were passed >> something bogus >> 147: // or an unexportable P11 key > > Still has typo "Objects", should be "object". > BTW, I still strongly feel that it can be combined into a byte[] instead of a > SecretKey object. Filling in with additional information from our offline discussion: For the current phrasing, the plural is actually correct. Perhaps, as you suggested offline, the comment could be rephrased. For the second portion (after `BTW`), this has been covered elsewhere, so I'm not considering it part of **this** review comment. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1737062798
