On Wed, 28 Aug 2024 20:44:10 GMT, Kevin Driver <kdri...@openjdk.org> wrote:

>> Introduce an API for Key Derivation Functions (KDFs), which are 
>> cryptographic algorithms for deriving additional keys from a secret key and 
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>> 
>> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924).
>
> Kevin Driver has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - consistency with wording for addIKM and addSalt
>  - another round of code review comments

src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 60:

> 58:  * AlgorithmParameterSpec kdfParameterSpec =
> 59:  *             HKDFParameterSpec.ofExtract()
> 60:  *                              .addIKM(label)

.addIKM(label) need to be removed here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1736675373

Reply via email to