On Tue, 27 Aug 2024 12:48:31 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed comment, added test contributed by Weijun
>
> src/java.base/share/classes/sun/security/provider/SHA3.java line 441:
>
>> 439: }
>> 440:
>> 441: public static abstract class SHA3XOF extends SHA3 {
>
> let's use blessed modifiers order
> Suggestion:
>
> public abstract static class SHA3XOF extends SHA3 {
Fixed.
> src/java.base/share/classes/sun/security/provider/SHA3.java line 446:
>
>> 444: }
>> 445: public void update(byte in) {
>> 446: if (squeezeOffset != -1) {
>
> Suggestion:
>
> if (squeezeOffset != -1) {
Fixed.
> src/java.base/share/classes/sun/security/provider/SHA3.java line 452:
>
>> 450: }
>> 451: public void update(byte[] in, int off, int len) {
>> 452: if (squeezeOffset != -1) {
>
> Suggestion:
>
> if (squeezeOffset != -1) {
Fixed.
> src/java.base/share/classes/sun/security/provider/SHA3.java line 459:
>
>> 457:
>> 458: public void update(byte[] in) {
>> 459: if (squeezeOffset != -1) {
>
> Suggestion:
>
> if (squeezeOffset != -1) {
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20631#discussion_r1732808656
PR Review Comment: https://git.openjdk.org/jdk/pull/20631#discussion_r1732808901
PR Review Comment: https://git.openjdk.org/jdk/pull/20631#discussion_r1732809087
PR Review Comment: https://git.openjdk.org/jdk/pull/20631#discussion_r1732809322
