On Fri, 16 Aug 2024 18:05:25 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>>> Use the name `inputKeyMaterial` instead of `inputKey` for consistency? >>> Seems easier to use `byte[]` for its type since all you need is just the >>> bytes. >> >> We can consider a rename of this parameter. See related comments for why we >> would use SecretKey instead of byte[]. > > Well, I don't share your comments/reason on why SecretKey is needed. A portion of this one is addressed in https://github.com/openjdk/jdk/pull/20301/commits/c6f491cd05c76088e6431b2ba9d4ab42b29e4055. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1720361177
