On Thu, 15 Aug 2024 20:26:50 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> addressed several review comments, namely: - renaming the getParameters
>> method - renaming the AlgorithmParameterSpec object - address some javadoc
>> exception messages - add some information to KDF class private constructor
>> javadocs - other general cleanup
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
> line 293:
>
>> 291: * {@code HkdfParameterSpec}
>> 292: */
>> 293: protected byte[] hkdfExtract(SecretKey inputKey, byte[] salt)
>
> Use the name `inputKeyMaterial` instead of `inputKey` for consistency? Seems
> easier to use `byte[]` for its type since all you need is just the bytes.
This method can be made "private" since there is no need for sub-class to
override it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1718957256
