On Wed, 7 Aug 2024 21:37:23 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits since the last revision: >> >> - update test to include Spi updates >> - Update with latest from master >> >> Merge remote-tracking branch 'origin/master' into kdf-jep-wip >> # Please enter a commit message to explain why this merge is necessary, >> # especially if it merges an updated upstream into a topic branch. >> # >> # Lines starting with '#' will be ignored, and an empty message aborts >> # the commit. >> - add engineGetKDFParameters to the KDFSpi >> - code review comment fix for javadoc specification >> - change course on null return values from derive methods >> - code review comments >> - threading refactor + code review comments >> - review comments >> - review comments >> - update code snippet type in KDF >> - ... and 6 more: https://git.openjdk.org/jdk/compare/b0ba5cfc...dd2ee48f > > src/java.base/share/classes/javax/crypto/KDF.java line 52: > >> 50: * of methods. For <a href="https://www.rfc-editor.org/rfc/rfc5869";>RFC >> 5869</a>, >> 51: * KDF algorithm names follow a naming convention of >> 52: * <em>Algorithm</em>With<em>PRF</em>. For instance, a KDF >> implementation of > > I only see HKDF mentioned in RFC 5869. There is no naming convention of > <Algorithm>With<PRF> anywhere. Is there any other spec/standard or crypto > libraries using this naming? @valeriepeng: There are `Cipher`s with this convention, namely: `PBEWithHmacSHA512/256AndAES_256` and many others. In addition, there are corresponding `AlgorithmParameters` and `SecretKeyFactory` declarations. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1715406664
