On Fri, 2 Aug 2024 19:19:54 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). > > Kevin Driver has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 16 additional > commits since the last revision: > > - update test to include Spi updates > - Update with latest from master > > Merge remote-tracking branch 'origin/master' into kdf-jep-wip > # Please enter a commit message to explain why this merge is necessary, > # especially if it merges an updated upstream into a topic branch. > # > # Lines starting with '#' will be ignored, and an empty message aborts > # the commit. > - add engineGetKDFParameters to the KDFSpi > - code review comment fix for javadoc specification > - change course on null return values from derive methods > - code review comments > - threading refactor + code review comments > - review comments > - review comments > - update code snippet type in KDF > - ... and 6 more: https://git.openjdk.org/jdk/compare/071ad772...dd2ee48f src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java line 468: > 466: "com.sun.crypto.provider.HkdfKeyDerivation$HkdfSHA384"); > 467: ps("KDF", "HKDFWithHmacSHA512", > 468: "com.sun.crypto.provider.HkdfKeyDerivation$HkdfSHA512"); Have you considered names such as HKDFWithSHA256? The "Hmac" part is sort of implied by the HKDF (Hmac-based Key Derivation Function). This also better matches the names used in [RFC 8619](https://datatracker.ietf.org/doc/html/rfc8619 ) which defines OIDs for HKDF. Now that we are adding support for HKDF, maybe add these oids to KnownOIDs? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1702420728
