On Thu, 25 Jul 2024 19:29:05 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). > > Kevin Driver has updated the pull request incrementally with two additional > commits since the last revision: > > - update code snippet type in KDF > - add preview annotation to KDFParameters Couple of comments so far. src/java.base/share/classes/java/security/KDFParameters.java line 37: > 35: * <p> > 36: * Typically, a {@code KDFParameters} object is passed as a parameter to > one of > 37: * the {@link javax.crypto.KDF#getInstance(String, KDFParameters) > KDF.getInstance} methods. The {@code getInstance} Nit: try to keep lines within 80 characters. src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 84: > 82: @JEP(number=476, title="Module Import Declarations", > status="Preview") > 83: MODULE_IMPORTS, > 84: @JEP(number=478, title="Key Derivation", status="Preview") This should probably match the title of the JEP: "Key Derivation Function API". ------------- PR Review: https://git.openjdk.org/jdk/pull/20301#pullrequestreview-2202257984 PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1693327259 PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1693333396
