On Mon, 20 May 2024 16:11:35 GMT, Mark Powers <mpow...@openjdk.org> wrote:

> Are there any existing interoperability tests?

Not with real KDCs, but I can probably enhance the test to cover the case when 
this prop is not set.

> src/java.security.jgss/share/classes/sun/security/krb5/PrincipalName.java 
> line 634:
> 
>> 632:         // if (this.nameType != pname.nameType) {
>> 633:         //      matched = false;
>> 634:         // }
> 
> Can this dead code be removed?

Maybe not. At least this will remind future maintainers not to add it back.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19216#issuecomment-2120770983
PR Review Comment: https://git.openjdk.org/jdk/pull/19216#discussion_r1606979800

Reply via email to