On Fri, 10 May 2024 13:07:30 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> Add `Cipher::export` API.
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   rename

src/java.base/share/classes/javax/crypto/Cipher.java line 2625:

> 2623:      * @since 23
> 2624:      */
> 2625:     public final SecretKey exportKey(byte[] context, String algorithm, 
> int length) {

You've probably thought about this already but adding a final method to a 
non-final class with an accessible constructor is source and binary 
incompatible.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18409#discussion_r1596731501

Reply via email to