On Thu, 9 May 2024 16:19:36 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains ten commits: > > - move the test to the correct directory, which was already created > - tests passing > - start deriveKey > - remove SHA224 mentions > - remove SHA224 mentions > - additional helper methods > - parameter validation for impl > - parameter validation for impl > - initial commit into open src/java.base/share/classes/javax/crypto/KDFSpi.java line 35: > 33: /** > 34: * This class defines the <i>Service Provider Interface</i> (<b>SPI</b>) > for the > 35: * <code>KeyDerivation</code> class. s/KeyDerivation/KDF/ src/java.base/share/classes/javax/crypto/KDFSpi.java line 65: > 63: > 64: /** > 65: * Derive a key, returned as a {@code Key}. s/Key/SecretKey/ src/java.base/share/classes/javax/crypto/KDFSpi.java line 98: > 96: * > 97: * @return a byte array whose length matches the length field in the > processed > 98: * {@code DerivationParameterSpec} and containing the next bytes of > output from the key s/DerivationParameterSpec/KDFParameterSpec/ (multiple places) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1595766355 PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1595764570 PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1595764166
