On Fri, 22 Mar 2024 22:25:47 GMT, rebarbora-mckvak <d...@openjdk.org> wrote:
>> This fixes the defect described at >> https://bugs.openjdk.org/browse/JDK-8313367 >> >> If the process does not have write permissions, the store is opened as >> read-only (instead of failing). >> >> Please note that permissions to use a certificate in a local machine store >> must be granted - in a management console, select a certificate, right-click >> -> All tasks... -> Manage Private Keys... -> add Full control to user. > > rebarbora-mckvak has updated the pull request incrementally with one > additional commit since the last revision: > > 8313367: signHash looks for a key in either user or machine store The code change looks good to me. I think it's OK to show an entry as a certificate entry if the private key is not available. After all, the certificates in both entries are treated as trusted. I'll run some tests and approve it. BTW, please update the copyright year of the class. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16687#issuecomment-2047750644
