On Thu, 21 Mar 2024 17:13:46 GMT, Bill Huang <[email protected]> wrote:
>> This task addresses an essential aspect of our testing infrastructure: the
>> proper handling and cleanup of temporary files and socket files created
>> during test execution. The motivation behind these changes is to prevent the
>> accumulation of unnecessary files in the default temporary directory, which
>> can affect the system's storage and potentially influence subsequent test
>> runs.
>>
>> Our review identified that several tests create temporary files or socket
>> files without ensuring their removal post-execution.
>> - Direct calls to java.io.File.createTempFile and
>> java.nio.file.Files.createTempFile without adequate cleanup.
>> - Tests using NIO socket channels with StandardProtocolFamily.UNIX, not
>> explicitly removing socket files post-use.
>
> Bill Huang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed potential NPE issues.
test/jdk/java/nio/channels/unixdomain/Bind.java line 162:
> 160: // address with space should work
> 161: checkNormal(() -> {
> 162: UnixDomainSocketAddress usa =
> UnixDomainSocketAddress.of("with space");
Suggestion:
UnixDomainSocketAddress usa = UnixDomainSocketAddress.of("with
space");
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18352#discussion_r1538701870
