On Thu, 21 Mar 2024 02:23:20 GMT, Prasadrao Koppula <pkopp...@openjdk.org> wrote:
>> test/jdk/javax/net/ssl/TLSv13/EngineOutOfSeqCCS.java line 253: >> >>> 251: } >>> 252: >>> 253: private static void log(String str) { >> >> I suggest method `log` accepts `String...` instead of `String`. >> This method can concatenate the strings, then its callers don't need to use >> so many `+` to concatenate the log. > > We have multiple options to pass String ('+')/ String[]/ > String../.join()/StringBuilder/.. I thought using '+'is not a bad idea I didn't mean `+` is bad. Method `log` can use `+` to join the elements in a string array, then the method callers don't need to concatenate the strings, instead, they only pass the strings themselves into `log`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18372#discussion_r1533186515