On Thu, 14 Mar 2024 03:12:30 GMT, John Jiang <jji...@openjdk.org> wrote:
>> In method `X509Authentication::createServerPossession`, it looks unnecessary >> to define variable `serverAlias` out of the for-loop. >> It may be better to move `serverAlias` into that loop to narrow down the >> scope. > > John Jiang has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into JDK-8327182 > - 8327182: Move serverAlias into the loop Looks good to me. Did you run all JSSE security regression tests? ------------- Marked as reviewed by mullan (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18100#pullrequestreview-1938970920
