On Thu, 7 Mar 2024 16:53:22 GMT, Korov <d...@openjdk.org> wrote: >> Removing unused parameter `defval` in `SocketPermission.initEphemeralPorts`, >> so the variable `PRIV_PORT_MAX` and `DEF_EPH_LOW` unused too. >> >> Removing unused parameter `cname` in `SocketPermission.authorizedIPv4` and >> `SocketPermission.authorizedIPv6`. >> >> Parameter 'action' must be not empty so `a.length > 0`, the check `a.length >> - 1 < 0` can be removed. > > Korov has updated the pull request incrementally with one additional commit > since the last revision: > > revert change
@Korov I did a round of testing and results came back green. You're good to go. The SecurityManager has been deprecated for removal, so maybe it would be better to stay away from SecurityManager related classes from now on unless there some strong reason to make a change. ------------- Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18086#pullrequestreview-1927730456
