On Tue, 6 Feb 2024 18:46:30 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Oli Gillespie has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright year > > src/java.base/unix/classes/sun/security/provider/NativePRNG.java line 207: > >> 205: // constructor, called by the JCA framework >> 206: public NativePRNG(SecureRandomParameters params) { >> 207: super(); > > nit: maybe super() not needed? Same goes for the Blocking and NonBlocking > ctors. It was already there before, but yes it doesn't do anything useful. The other impls I've checked don't use it, so I'll remove. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17560#discussion_r1481196524