On Thu, 11 Jan 2024 13:33:54 GMT, John Jiang <jji...@openjdk.org> wrote:

> ECDHKeyAgreement should validate the parameters before assigning them to the 
> fields.

test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 90:

> 88:         KeyAgreement ka = KeyAgreement.getInstance("ECDH");
> 89:         ka.init(kpP256.getPrivate());
> 90:         try {

Should this be assertThrows like the other ones?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17373#discussion_r1451066698

Reply via email to