On Tue, 2 Jan 2024 21:54:19 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Do you think we can remove `PKCS9Attributes.getAttributes()` entirely or >> should we just modify it to not use `PKCS9_OIDS` anymore? > > I think we can remove both. There is no need to keep a useless method as long > as it's not an exported API. The test `sun/security/x509/AlgorithmId/NonStandardNames.java` uses the `getAttributes()` though it seems it does so just to verify the method works. I'll go ahead and remove that method call from the test unless you think that would be a bad idea ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17132#discussion_r1449493698
