On Mon, 18 Dec 2023 17:49:04 GMT, Raffaello Giulietti <rgiulie...@openjdk.org>
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Event enabled on profile.jfc but disabled on default.jfc.
src/jdk.jfr/share/classes/jdk/jfr/events/SerializationMisdeclarationEvent.java
line 41:
> 39: @Description("Methods and fields misdeclarations")
> 40: @MirrorEvent(className =
> "jdk.internal.event.SerializationMisdeclarationEvent")
> 41: @RemoveFields({"duration", "stackTrace", "thread"})
The field should be "eventThread" instead of "thread"
src/jdk.jfr/share/classes/jdk/jfr/events/SerializationMisdeclarationEvent.java
line 45:
> 43:
> 44: @Label("Class")
> 45: public Class<?> cls;
We have often used a prefix, i.e. misdeclaredClass, to avoid using a reserved
word. We try to stay out of abbreviations.
src/jdk.jfr/share/classes/jdk/jfr/events/SerializationMisdeclarationEvent.java
line 48:
> 46:
> 47: @Label("Kind")
> 48: public int kind;
What is the use case for error codes? Are they public or an implementation
detail?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17129#discussion_r1431226200
PR Review Comment: https://git.openjdk.org/jdk/pull/17129#discussion_r1431227843
PR Review Comment: https://git.openjdk.org/jdk/pull/17129#discussion_r1431229900
