On Wed, 6 Dec 2023 16:48:57 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
>> Hi, >> >> I need a review for a new internal buffer class called AEADBufferStream. >> AEADBufferStream extends ByteArrayOutputStream, but eliminates some data >> checking and copying that are not necessary for what GaloisCounterMode.java >> and ChaCha20Cipher.java need. >> >> The changes greatest benefit is with decryption operations. >> ChaCha20-Poly1305 had larger performance gains by adopting similar >> techniques that AES/GCM already uses. >> >> The new buffer shows up to 21% bytes/sec performance increase for decryption >> for ChaCha20-Poly1305 and 12% for AES/GCM. 16K data sizes saw a memory >> usage reduction of 46% with and 83% with ChaCha20-Poly1305. These results >> come from the JMH tests updated in this request and memory usage using the >> JMH gc profile gc.alloc.rate.norm entry >> >> thanks >> >> Tony > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > update This change did not introduce the problem. The test just exposed the problem that has existed since https://bugs.openjdk.org/browse/JDK-8247645 was integrated in JDK 20. A bug was filed: https://bugs.openjdk.org/browse/JDK-8321542 ------------- PR Comment: https://git.openjdk.org/jdk/pull/16487#issuecomment-1848083450
