> Hi, > > I need a review for a new internal buffer class called AEADBufferStream. > AEADBufferStream extends ByteArrayOutputStream, but eliminates some data > checking and copying that are not necessary for what GaloisCounterMode.java > and ChaCha20Cipher.java need. > > The changes greatest benefit is with decryption operations. > ChaCha20-Poly1305 had larger performance gains by adopting similar techniques > that AES/GCM already uses. > > The new buffer shows up to 21% bytes/sec performance increase for decryption > for ChaCha20-Poly1305 and 12% for AES/GCM. 16K data sizes saw a memory usage > reduction of 46% with and 83% with ChaCha20-Poly1305. These results come > from the JMH tests updated in this request and memory usage using the JMH gc > profile gc.alloc.rate.norm entry > > thanks > > Tony
Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision: update ------------- Changes: - all: https://git.openjdk.org/jdk/pull/16487/files - new: https://git.openjdk.org/jdk/pull/16487/files/38928807..b383888c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=16487&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16487&range=03-04 Stats: 18 lines in 3 files changed: 0 ins; 3 del; 15 mod Patch: https://git.openjdk.org/jdk/pull/16487.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16487/head:pull/16487 PR: https://git.openjdk.org/jdk/pull/16487
