On Mon, 23 Oct 2023 16:23:55 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
> Remove the hardcoded maximum heap size. > > Verified that the benchmark now passes with 100 threads given sufficient heap: > > make test TEST=micro:CacheBench MICRO="OPTIONS=-t 100;JAVA_OPTIONS=-Xmx16g" Marked as reviewed by redestad (Reviewer). > Looks ok to me but I would request a review from @cl4es since he introduced > the limit in #9189. The `-Xmx1g` was there before #9189 (I only modified the line to add `value = 3` to reduce number of forks). ------------- PR Review: https://git.openjdk.org/jdk/pull/16315#pullrequestreview-1723600080 PR Comment: https://git.openjdk.org/jdk/pull/16315#issuecomment-1804774258
