On Wed, 4 Oct 2023 04:08:13 GMT, Julian Waters <jwat...@openjdk.org> wrote:

>> I tested the new approach on gcc, it worked, so I'll commit it here
>
> I've changed it to use the split approach, but this feels like a hack to me. 
> I wonder if there's a better way of doing this?

well goto was always a hack; less hacky solution would involve splitting the 
giant function into smaller parts, so that replacing goto with an else block 
doesn't increase indentation too much. But if it ain't broke...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15996#discussion_r1345304742

Reply via email to