On Mon, 11 Sep 2023 15:57:22 GMT, 温绍锦 <d...@openjdk.org> wrote:
>> Some codes in core libs are duplicated, including: >> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS >> java.util.DecimalDigits::size -> java.lang.Long.stringSize >> >> We can reduce duplication through JavaLangAccess, which is also needed in >> other places, such as: >> https://github.com/openjdk/jdk/pull/15555 > > 温绍锦 has updated the pull request incrementally with one additional commit > since the last revision: > > revert code format Changes requested by rriggs (Reviewer). src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 1: > 1: /* Can git be convinced to show this as a rename instead of a delete and add? The history will be cleaner. src/java.base/share/classes/jdk/internal/util/OctalDigits.java line 41: > 39: * Singleton instance of OctalDigits. > 40: */ > 41: public static final Digits INSTANCE = new OctalDigits(); The constructor should be after the field definitions. Don't let some tool reformat the code and move things around. ------------- PR Review: https://git.openjdk.org/jdk/pull/15651#pullrequestreview-1620644060 PR Review Comment: https://git.openjdk.org/jdk/pull/15651#discussion_r1321958613 PR Review Comment: https://git.openjdk.org/jdk/pull/15651#discussion_r1321960820
