On Wed, 23 Aug 2023 18:21:28 GMT, Rajan Halade <rhal...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More review feedbacks
>
> test/jdk/sun/security/pkcs11/Signature/KeyAndParamCheckForPSS.java line 117:
>
>> 115: System.out.println("=> Skip; no PSS support");
>> 116: return;
>> 117: }
>
> else...Should the test be marked as failed?
Sure, should not happen but good to check to be sure.
> test/jdk/sun/security/pkcs11/Signature/SignatureTestPSS.java line 117:
>
>> 115: System.out.println(" => Skip; no PSS support");
>> 116: return;
>> 117: }
>
> Same here, should test fail here?
Sure.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15217#discussion_r1306088345
PR Review Comment: https://git.openjdk.org/jdk/pull/15217#discussion_r1306090152
