On Thu, 3 Aug 2023 20:51:33 GMT, Valerie Peng <valer...@openjdk.org> wrote:
> This change addresses the scenario where a certificate is first stored as > part of a certificate chain and then stored again as a certificate > corresponding to a PrivateKey entry. Newer version of NSS errors out with > CKR_GENERAL_ERROR with the 2nd store, i.e. C_CreateObject() call. > > Proposed fix is to check for match before calling C_CreateObject(), if a > match is found, set its alias instead. Marked as reviewed by mbaesken (Reviewer). Looks okay to me and seems to fix the issues we faced in our test infrastructure; seems to need backport to jdk21. Would be great to have a second reviewer who is working more actively in this area of the JDK codebase. ------------- PR Review: https://git.openjdk.org/jdk/pull/15146#pullrequestreview-1573515639 PR Comment: https://git.openjdk.org/jdk/pull/15146#issuecomment-1674622671
