On Wed, 21 Jun 2023 18:46:41 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
> In this PR I updated the EC key size and updated the regular expressions used > to parse the output of the jarsigner. In addition to updating default key > sizes base on Java version, I also updated the logic for determining the > default signing algorithm which is based on the version of jarsigner/java > used to sign the jar file and the size of the key being used. > > I ran this test with JDKs 17.0.8, 20.0.2, and 21b26. Marked as reviewed by rhalade (Reviewer). test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java line 26: > 24: /* > 25: * @test > 26: * @bug 8217375 8260286 8267319 8292704 Suggestion: * @bug 8217375 8260286 8267319 since this is test only update, you don't need to add bug id here. test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java line 861: > 859: } > 860: > 861: Suggestion: ------------- PR Review: https://git.openjdk.org/jdk/pull/14602#pullrequestreview-1493730690 PR Review Comment: https://git.openjdk.org/jdk/pull/14602#discussion_r1238856523 PR Review Comment: https://git.openjdk.org/jdk/pull/14602#discussion_r1238857117
