On Wed, 3 May 2023 11:26:32 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
>> In this PR, I added methods to the TransportContext class to synchronize
>> access to the handshakeContext field. I also updated locations in the code
>> that rely on the handshakeContext field to not be null to use the
>> synchronized methods.
>>
>> Thanks
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> made handshake context lock final
src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java line 914:
> 912: @Override
> 913: public SSLSession getHandshakeSession() {
> 914: engineLock.lock();
I'm not very sure of this update. By removing the enginLock on socket/engine
level here, is it possible there are two threads that one read the handshake
session and another on write?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13742#discussion_r1231827430
