On Tue, 6 Jun 2023 14:12:22 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Fixed `engineInitSign` in `DSA.java` and added `SecureRandomReset.java` to >> DSA tests > > test/jdk/sun/security/provider/DSA/SecureRandomReset.java line 28: > >> 26: * @bug 8308474 >> 27: * @summary Test that calling initSign resets RNG >> 28: * @run main SecureRandomReset > > Not necessary if this is the only action in the test. Some people think this > is clearer, though. For me, I have copied an existing test to create a new > one and forgot to modify this line before. Would you prefer I take this out? I see the concern about accidentally copy/pasting incorrect test information but having the bug number is kind of nice ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14273#discussion_r1220030524
