On Wed, 24 May 2023 19:23:39 GMT, Martin Balao <mba...@openjdk.org> wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java line
>> 71:
>>
>>> 69: private Mac prf;
>>> 70: @SuppressWarnings("serial")
>>> 71: private Cleaner.Cleanable cleaner;
>>
>> why not directly mark "cleaner" as transient? Then you should not need
>> `@SuppressWarnings` tag.
>
> We thought about transient and then changed to suppress the warning to keep
> consistency with ```private Mac prf```. I'll change both to transient then.
Sure, I think using transient is clearer.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12396#discussion_r1210638477
