On Wed, 24 May 2023 18:36:34 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Martin Balao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #3)
>>
>> Co-authored-by: Francisco Ferrari <fferr...@redhat.com>
>> Co-authored-by: Martin Balao <mba...@redhat.com>
>
> src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java line
> 71:
>
>> 69: private Mac prf;
>> 70: @SuppressWarnings("serial")
>> 71: private Cleaner.Cleanable cleaner;
>
> why not directly mark "cleaner" as transient? Then you should not need
> `@SuppressWarnings` tag.
We thought about transient and then changed to suppress the warning to keep
consistency with ```private Mac prf```. I'll change both to transient then.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12396#discussion_r1204661418
