On Tue, 23 May 2023 18:15:57 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 17 additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'upstream/master' into JDK-8294985 >> - additional code review comments >> - rename class and remove bug id from test header >> - removing block that isn't reached >> - fix bug id in test header >> - reworked example into a jtreg test >> - whitespace adjustments >> - all review comments applied >> - optimize imports and change toString >> - review comments addressed >> - ... and 7 more: https://git.openjdk.org/jdk/compare/47d94ef0...d9f0c667 > > test/jdk/sun/security/ssl/SSLEngineImpl/TestBadDNForPeerCA.java line 29: > >> 27: * @summary verify correct exception handling in the event of an >> unparseable >> 28: * DN in the peer CA >> 29: */ > > Please run tests for JSSE/TLS in othervm mode. Otherwise, the behavior may > be impacted with each other, and the failure debugging is pretty hard. For > an example, please refer to > test/jdk/javax/net/ssl/SSLEngine/IllegalHandshakeMessage.java See: https://github.com/openjdk/jdk/pull/13466/commits/67506a21231793df250e08ea090e6c3461d7b4f8 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1207388554