On Thu, 18 May 2023 13:39:10 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> Update XML Security for Java to 3.0.2. Some change to tests:
>> 
>> 1. A new `HereFunction.java` to test the new security property 
>> "jdk.xml.dsig.hereFunctionSupported".
>> 2. EdDSA does not support `KeyValue`. Use X.509 certificate instead.
>
> Weijun Wang has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 10 additional 
> commits since the last revision:
> 
>  - Merge branch 'master' into 8305972
>  - fix here
>  - update version in comment
>    
>    only in patch2:
>    unchanged:
>  - add here() back
>  - Merge branch 'master' into 8305972
>  - comment for new test
>  - no more secret exports, one message change
>  - more comment and spec refine
>  - cleanup commented out code and unnecessary bug id
>  - the change

Just one wording suggestion. Otherwise looks good

-------------

Marked as reviewed by mullan (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13840#pullrequestreview-1429167827

Reply via email to