On Mon, 8 May 2023 21:14:39 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add NPE for SecureRandom(byte[]) ctor and setSeed(byte[]) method. > > test/jdk/sun/security/pkcs11/SecureRandom/NextBytesNull.java line 1: > >> 1: /* > > Since the null checks are now all in `SecureRandom`, it doesn't seem that > useful to check the individual providers. Maybe combine these tests and just > check that the API methods throw NPE? Sounds reasonable, I will give it a try. Thanks~ ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13788#discussion_r1190241279
