On Tue, 2 May 2023 18:42:36 GMT, Rajan Halade <rhal...@openjdk.org> wrote:
>> This PR was requested by awar...@google.com. The updates were provided by >> awar...@google.com. > >> > > >> > >> > >> > I have infra tests for interop implemented. @jianglizhou, please check >> > https://github.com/openjdk/jdk/compare/master...rhalade:jdk:googletrust-certify?expand=1 >> >> @rhalade, thanks! I have a minor comment below for your >> test/jdk/security/infra/java/security/cert/CertPathValidator/certification/GoogleCA.java >> test. I'll defer to @[awar...@google.com](mailto:awar...@google.com) for >> detailed review, as I don't have much context. >> >> Please fix the bug id, `8303394`: >> >> ``` >> /* >> * @test >> * @bug 8303394 >> * @summary Interoperability tests with Google's GlobalSign R4 and GTS Root >> certificates >> ... >> ``` >> >> Could you please also let me know your plan on committing the GoogleCA.java? >> Do you plan to create a PR? > > You can include this contribution in your PR. Then it will be easier to > backport to JDK 20u as one changeset. I updated bug id in the changeset. > Looks good. Please also wait for approval from @rhalade before integrating. Thanks @seanjmullan. Will wait for @rhalade's approval as well. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13754#issuecomment-1533324346
