On Thu, 13 Apr 2023 20:59:17 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> spec change, getAlgorithm > > src/java.base/share/classes/javax/crypto/KEM.java line 168: > >> 166: * is not supported by the decapsulator >> 167: */ >> 168: public SecretKey decapsulate(byte[] encapsulation, > > WDYT about throwing IllegalArgumentException if the size of encapsulation is > not equal to encapsulationSize()? > > If not, I think you should add a sentence to the @param encapsulation such as > "The size must be equal to ..., or a DecapsulateException will be thrown." I'll choose the latter. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1166163967
