On Thu, 13 Apr 2023 17:08:44 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> The KEM API and DHKEM impl. Note that this PR uses new methods in >> https://github.com/openjdk/jdk/pull/13250. > > src/java.base/share/classes/javax/crypto/KEM.java line 430: > >> 428: /** >> 429: * Returns a {@code KEM} object that implements the specified >> algorithm >> 430: * and supports the specified {@code KEMParameterSpec} parameters > > There are no parameters for this method. Oops, yes. > src/java.base/share/classes/javax/crypto/KEM.java line 441: > >> 439: * to {@link #getInstance(String)}. >> 440: * @return the new {@code KEM} object >> 441: * @throws NoSuchAlgorithmException if no {@code Provider} supports >> a > > This sounds like the provider argument is ignored. Maybe add some more words > to take into account both cases "if a {@code provider} is specified and it > does not support the specified KEM algorithm, or if {@code provider} is > {@code null} and there is no provider that supports a KEM implementation of > the specified algorithm" Correct. I must be copying text from the method without a provider argument. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1165825088 PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1165826805
