On Thu, 12 Jan 2023 16:03:34 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> Matthew Donovan has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - renamed IllegalRecordVersion to HandshakeWithInvalidRecordVersion
>> - Updated IllegalRecordVersion
>> - reverted change in ProtocolVersion, updated IllegalRecordVersion
>
> test/jdk/javax/net/ssl/SSLEngine/HandshakeWithInvalidRecordVersion.java line
> 51:
>
>> 49: private static final String TRUSTSTORE_PATH =
>> 50: System.getProperty("test.src", "./") + "/" + PATH_TO_STORES +
>> 51: "/" + TRUSTSTORE_FILE;
>
> It would be nice to avoid to use binary files. Would you mind to check if
> test/jdk/javax/net/ssl/templates/SSLContextTemplate.java could be used for
> the generation of SSLContext (for example
> test/jdk/javax/net/ssl/templates/SSLEngineTemplate.java)?
There are few other tests that need update as well. We should create backlog
item to update all these tests to use the SSLEngineTemplate to generate
SSLContext.
-------------
PR: https://git.openjdk.org/jdk/pull/11929
