On Thu, 22 Dec 2022 18:42:34 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> Matthew Donovan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added additional protocols > > test/jdk/javax/net/ssl/SSLEngine/Basics.java line 63: > >> 61: private static final String TLS13_PROTOCOL = "TLSv1.3"; >> 62: >> 63: private static final String TLS12_PROTOCOL = "TLSv1.2"; > > It looks like that the three constants are not used any longer? +1. These are to be passed as parameter to runTest. Either define and use all as constant or remove these. ------------- PR: https://git.openjdk.org/jdk/pull/11760