On Wed, 9 Nov 2022 22:44:59 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> `EDIPartyName` should not have a null `partyName`.
>> 
>> Inside `X400Name` it should be a `DerValue` instead of arbitrary byte array. 
>> Note: in `GeneralSubtrees.java`, an `X400Name` is created with a null 
>> content. This would lead to an NPE anyway. A future fix might be needed.
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   add test
>   
>   only in patch2:
>   unchanged:

src/java.base/share/classes/sun/security/x509/EDIPartyName.java line 66:

> 64:     public EDIPartyName(String assignerName, String partyName) {
> 65:         this.assigner = assignerName;
> 66:         this.party = Objects.requireNonNull(partyName);

It looks like this constructor is not used.  Is if safe to remove it?

-------------

PR: https://git.openjdk.org/jdk/pull/11071

Reply via email to