On Tue, 8 Nov 2022 18:38:59 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
> Hi, > > May I have the micro-benchmark code reviewed for EC signature algorithms? > The benchmarking now is focused on EC algorithms, more algorithms (e.g., > RSA/PSS based) may be added later if needed. > > Thanks, > Xuelei One small comment. test/micro/org/openjdk/bench/java/security/Signatures.java line 60: > 58: > 59: String signName = switch (curveName) { > 60: case "secp256r1" -> "Sha256WithECDSA"; We usually write "SHA256withECDSA". ------------- Marked as reviewed by weijun (Reviewer). PR: https://git.openjdk.org/jdk/pull/11043