On Tue, 8 Nov 2022 15:15:38 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> test/jdk/java/security/Exceptions/ChainingConstructors.java line 208:
>>
>>> 206: throw new SecurityException("Test 17 failed");
>>> 207: }
>>> 208: */
>>
>> I don't know why this is commented out, but when I uncomment it, the test
>> still passes, so I would include a test for `SSLException` below.
>
> Hi Sean, the summary says that the test is about "java.security Exceptions"
> so javax.net.ssl.SSLException.java from another package might not fit in,
> maybe that's why it was commented out.
> Should I still add it ? If so, the summary comment might need a little bit
> adjustment, what about this "Test constructors for exception chaining of
> security-related exceptions" ?
Good point. I think it is ok to make an exception (no pun intended) for
`SSLException` for this test. Changing the summary comment to your suggestion
is fine with me.
-------------
PR: https://git.openjdk.org/jdk/pull/11016
