On Wed, 26 Oct 2022 21:11:33 GMT, Jamil Nimeh <jni...@openjdk.org> wrote:
>> 10% is not a negligible impact. I see your point about AVX512 reaping the >> rewards of this change, but there are plenty of x86_64 systems without >> AVX512 that will be impacted, not to mention other platforms like aarch64 >> which (for this change at least) will never see the benefits from the >> intrinsic. >> >> I don't have any suggestions right at this moment for how this could be >> streamlined at all to help reduce the pain for non-AVX512 systems. Worth >> looking into though. > > One small thing maybe: It doesn't look like R in `processMultipleBlocks` and > `rbytes` ever changes, so maybe there's no need to repeatedly > serialize/deserialize them on every call to engineUpdate? There is already > an `r` that is attached to the object that is an IntegerModuloP. Could that > be used in `processMultipleBlocks` and perhaps a private byte[] for a > serialized r is also a field in Poly1305 that can be passed into the > intrinsic method rather than creating it every time? It could be set in > `setRSVals`. Perhaps we can recover a little performance there? > 10% is not a negligible impact. I see your point about AVX512 reaping the > rewards of this change, but there are plenty of x86_64 systems without AVX512 > that will be impacted, not to mention other platforms like aarch64 which (for > this change at least) will never see the benefits from the intrinsic. > > I don't have any suggestions right at this moment for how this could be > streamlined at all to help reduce the pain for non-AVX512 systems. Worth > looking into though. Do you suggest using white box APIs for CPU feature query during poly static initialization and perform multi block partitioning only for relevant platforms and keep the original implementation sacrosanct for other targets. VM does offer native white box primitives and currently its being used by tests infrastructure. ------------- PR: https://git.openjdk.org/jdk/pull/10582
